Remove Realm binaries from project and fix carthage building #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmairoldi
changed the title
|
This should be good for review now @danielgindi or @liuxuan30. Let me know what you think. |
|
seems still have dependency for Charts.framework to require Realm? |
|
I'm not sure I understand what you mean. But I think I'm gonna close this. I found a better way. |
|
never mind :) |
|
close in favour of #1422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change address two issues having to do with Carthage (#1326 and #1119).
This first change is removing the prebuilt binaries inside of the ChartsRealm project and replacing them with ones that come from Carthage when running "carthage bootstrap" or "carthage update". There has been a lot talk in #1119 about the possible solutions and to me this seems to be the best for now. This means that contributors wanting to update the ChartsRealm project will have to have Carthage install and run "carthage bootstrap" to get the Realm dependencies. A note in the CONTRIBUTING.md should be added for newcomers.
The second change sort of goes hand in hand with the first. It changes how ChartsRealm requires Charts.framework in order to work with Carthage. For whatever reason when building using Carthage most of the time it will pick the macOS version of Charts.framework (but not all of the time, its weird). So instead of having the ChartsRealm project depend on Charts.framework from the Charts project it now depends on Charts.framework built by Carthage.
I believe this addresses most of the Carthage issues. It seems to work consistently now.